natsquad.asp === Obvious problem will be when the number of countries > 10, as it means the logical sequencing of team ID's (negative?), and U-19=NatteamID-10 will be screwed. === I thought Line 75 had a logic error, but I read further down the page, and decided it wasn't :o) === Line 95 - does the dim noPlayers get assigned each time a new row is called? Can it be moved outside of the loop? === Line 169 uses the setlship function, but on batting and bowling form? I can see why it does, but slightly confusing. Could just create a function: function setform(arg) { return setlship(arg); } Not sure of the exact syntax, but I'm sure you get the idea. Same for Stamina and Experience. If the stamina/exp/form ever changes in such a way that the setlship function won't be of any use, then you've only got to change one function in function.asp (or wherever it currently is), instead of the (various?) squad pages. === Please change line 174 to: <%End If%> fitness. -----------^^^^^^^^ so that it finishes off the sentence! (same for the normal squad page!) === Form starting on Line 229, tidied up:
Not sure why: <%if sortOrder-1=0 isn't: <%if sortOrder==1 ? I'm going to do some test cases on this select element, just my own thoughts - I'll give you the results when I'm done.